Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1833)

Unified Diff: mojo/services/gpu/public/interfaces/command_buffer.mojom

Issue 816913004: Review nullability in the gpu and geometry interfaces. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/gpu/public/interfaces/command_buffer.mojom
diff --git a/mojo/services/gpu/public/interfaces/command_buffer.mojom b/mojo/services/gpu/public/interfaces/command_buffer.mojom
index 5301aeaa838fb928d973573375ec6840d16d8143..f071c68e600a4acd669b1cc9d6ed5e653da4cf0f 100644
--- a/mojo/services/gpu/public/interfaces/command_buffer.mojom
+++ b/mojo/services/gpu/public/interfaces/command_buffer.mojom
@@ -18,7 +18,7 @@ struct CommandBufferState {
interface CommandBufferSyncClient {
DidInitialize(bool success, GpuCapabilities capabilities);
- DidMakeProgress(CommandBufferState? state);
+ DidMakeProgress(CommandBufferState state);
};
interface CommandBufferSyncPointClient {
@@ -27,14 +27,14 @@ interface CommandBufferSyncPointClient {
[Client=CommandBufferClient]
interface CommandBuffer {
- Initialize(CommandBufferSyncClient? sync_client,
- CommandBufferSyncPointClient? sync_point_client,
- handle<shared_buffer>? shared_state);
+ Initialize(CommandBufferSyncClient sync_client,
+ CommandBufferSyncPointClient sync_point_client,
+ handle<shared_buffer> shared_state);
SetGetBuffer(int32 buffer);
Flush(int32 put_offset);
MakeProgress(int32 last_get_offset);
RegisterTransferBuffer(
- int32 id, handle<shared_buffer>? transfer_buffer, uint32 size);
+ int32 id, handle<shared_buffer> transfer_buffer, uint32 size);
DestroyTransferBuffer(int32 id);
// InsertSyncPoint returns the sync point returned via DidInsertSyncPoint.

Powered by Google App Engine
This is Rietveld 408576698