Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/files/important_file_writer.cc

Issue 816543004: Update from https://crrev.com/308996 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | base/memory/memory_pressure_listener.h » ('j') | build/module_args/v8.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/important_file_writer.cc
diff --git a/base/files/important_file_writer.cc b/base/files/important_file_writer.cc
index d7579abb112432f8e97be4a81d5c6b1ea1c484ba..d2562364dfe9cc4ed265b2c72a455a125661c606 100644
--- a/base/files/important_file_writer.cc
+++ b/base/files/important_file_writer.cc
@@ -27,10 +27,14 @@ namespace {
const int kDefaultCommitIntervalMs = 10000;
+// This enum is used to define the buckets for an enumerated UMA histogram.
+// Hence,
+// (a) existing enumerated constants should never be deleted or reordered, and
+// (b) new constants should only be appended at the end of the enumeration.
enum TempFileFailure {
FAILED_CREATING,
FAILED_OPENING,
- FAILED_CLOSING,
+ FAILED_CLOSING, // Unused.
FAILED_WRITING,
FAILED_RENAMING,
FAILED_FLUSHING,
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | base/memory/memory_pressure_listener.h » ('j') | build/module_args/v8.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698