Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/module_args/v8.gni

Issue 816543004: Update from https://crrev.com/308996 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/ios/grit_whitelist.txt ('k') | build/secondary/third_party/freetype/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/module_args/v8.gni
diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni
index 5825530ae4031db6a14fb1308054de10a1b68b96..4da793a5ef5744e128fb3abf98e85a9489b48b7a 100644
--- a/build/module_args/v8.gni
+++ b/build/module_args/v8.gni
@@ -6,7 +6,7 @@ if (is_android) {
import("//build/config/android/config.gni")
}
-# TODO(baixo) enable this once this lands:
-# https://codereview.chromium.org/749213004
-# v8_use_external_startup_data = is_android && !is_android_webview_build
+# Many V8 users in mojo do not support external startup data for V8, so
+# we disable it. If enabled, special care should be taken to ensure the
+# appropriate startup data is correctly bundled for android apps.
qsr 2014/12/19 14:30:22 The issue is not android apps, is all mojo app.
etiennej 2014/12/19 14:36:49 Done.
v8_use_external_startup_data = false
« no previous file with comments | « build/ios/grit_whitelist.txt ('k') | build/secondary/third_party/freetype/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698