mojo/tools/roll/build_v8.patch - Issue 816543004: Update from https://crrev.com/308996

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/tools/roll/build_v8.patch

Issue 816543004: Update from https://crrev.com/308996 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/tools/roll/build_v8.patch

diff --git a/mojo/tools/roll/build_v8.patch b/mojo/tools/roll/build_v8.patch

new file mode 100644

index 0000000000000000000000000000000000000000..d4646b96dbadffda021710c898fa00b7a3f81424

--- /dev/null

+++ b/mojo/tools/roll/build_v8.patch

@@ -0,0 +1,14 @@

+diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni

+index e4bbf46..5825530 100644

+--- a/build/module_args/v8.gni

++++ b/build/module_args/v8.gni

+@@ -6,5 +6,7 @@ if (is_android) {

+ import("//build/config/android/config.gni")

+ }

+-v8_use_external_startup_data =

+- !((is_android && is_android_webview_build) || is_chromeos || is_win)

++# TODO(baixo) enable this once this lands:

++# https://codereview.chromium.org/749213004

qsr 2014/12/19 12:03:25 The comment is incorrect. Please put one explainin

etiennej 2014/12/19 13:42:36 Done.

++# v8_use_external_startup_data = is_android && !is_android_webview_build

++v8_use_external_startup_data = false

« no previous file with comments | « gpu/gles2_conform_support/egl/display.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »