mojo/tools/roll/build_v8.patch - Issue 816543004: Update from https://crrev.com/308996

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/tools/roll/build_v8.patch

Issue 816543004: Update from https://crrev.com/308996 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni

	2 index e4bbf46..5825530 100644

	3 --- a/build/module_args/v8.gni

	4 +++ b/build/module_args/v8.gni

	5 @@ -6,5 +6,7 @@ if (is_android) {

	6 import("//build/config/android/config.gni")

	7 }

	8

	9 -v8_use_external_startup_data =

	10 - !((is_android && is_android_webview_build) \|\| is_chromeos \|\| is_win)

	11 +# TODO(baixo) enable this once this lands:

	12 +# https://codereview.chromium.org/749213004
	qsr 2014/12/19 12:03:25 The comment is incorrect. Please put one explainin The comment is incorrect. Please put one explaining why we need to disable this. etiennej 2014/12/19 13:42:36 Done. Show quoted text On 2014/12/19 12:03:25, qsr wrote: > The comment is incorrect. Please put one explaining why we need to disable this. Done.
	13 +# v8_use_external_startup_data = is_android && !is_android_webview_build

	14 +v8_use_external_startup_data = false

OLD	NEW

« no previous file with comments | « gpu/gles2_conform_support/egl/display.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »