Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: media/formats/mp4/mp4_stream_parser_unittest.cc

Issue 816353010: Implemented HEVC video demuxing and parsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to ToT Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/mp4_stream_parser_unittest.cc
diff --git a/media/formats/mp4/mp4_stream_parser_unittest.cc b/media/formats/mp4/mp4_stream_parser_unittest.cc
index 620b81f0bcbe54d8bbd96a67dc43505c5d09d2dd..e1cc96cbb666a5be4b5798bc1e1c901a48cd2f10 100644
--- a/media/formats/mp4/mp4_stream_parser_unittest.cc
+++ b/media/formats/mp4/mp4_stream_parser_unittest.cc
@@ -294,6 +294,14 @@ TEST_F(MP4StreamParserTest, VideoSamplesStartWithAUDs) {
ParseMP4File("bear-1280x720-av_with-aud-nalus_frag.mp4", 512);
}
+#if defined(ENABLE_HEVC_DEMUXING)
+TEST_F(MP4StreamParserTest, HEVC_in_MP4_container) {
wolenetz 2015/09/02 21:56:59 cast_shell_linux try bot doesn't seem to have run
wolenetz 2015/09/02 22:09:24 Hmm. More complicated than I initially thought. EN
servolk 2015/09/03 00:17:51 As we've discussed offline we are in the same situ
wolenetz 2015/09/08 19:53:10 Acknowledged.
+ InitializeParserAndExpectLiveness(DemuxerStream::LIVENESS_RECORDED);
+ scoped_refptr<DecoderBuffer> buffer = ReadTestDataFile("bear-hevc-frag.mp4");
+ EXPECT_TRUE(AppendDataInPieces(buffer->data(), buffer->data_size(), 512));
wolenetz 2015/09/02 20:43:18 ditto nit: I would think my recent changes would n
wolenetz 2015/09/02 22:09:24 See also my comment earlier in this test case.
servolk 2015/09/03 00:17:51 Indeed, the test wasn't running, because ENABLE_HE
wolenetz 2015/09/08 19:53:10 Acknowledged. Thanks for fixing.
+}
+#endif
+
TEST_F(MP4StreamParserTest, CENC) {
// Encrypted test mp4 files have non-zero duration and are treated as
// recorded streams.

Powered by Google App Engine
This is Rietveld 408576698