Implemented HEVC video demuxing and parsing

media/formats/mp4/mp4_stream_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
@@ skipping 276 matching lines @@
   EXPECT_FALSE(AppendDataInPieces(buffer->data(), buffer->data_size(), 512));
 }
 
 // Test a file where all video samples start with an Access Unit
 // Delimiter (AUD) NALU.
 TEST_F(MP4StreamParserTest, VideoSamplesStartWithAUDs) {
   EXPECT_MEDIA_LOG(VideoCodecLog("avc1.4d4028"));
   ParseMP4File("bear-1280x720-av_with-aud-nalus_frag.mp4", 512);
 }
 
+#if defined(ENABLE_HEVC_DEMUXING)
+TEST_F(MP4StreamParserTest, HEVC_in_MP4_container) {

[wolenetz, 2015/09/02 21:56:59]

cast_shell_linux try bot doesn't seem to have run this test.
Please fix.

[wolenetz, 2015/09/02 22:09:24]

Hmm. More complicated than I initially thought. ENABLE_HEVC_DEMUXING is
dependent on both chromecast==1 and proprietary_codecs==1
(https://codereview.chromium.org/816353010/diff/1090001/media/media.gyp). The
latter isn't defined for chromium trybots, just for official release builds. So
this test will not be exercised in Chromium waterfall and may rot. Please ensure
this passes on Chromecast downstream at least :)

[servolk, 2015/09/03 00:17:51]

As we've discussed offline we are in the same situation as MP4 here.
But we do have internal Chromecast tests with actual video stream playback
(including HEVC), so we got this covered.

[wolenetz, 2015/09/08 19:53:10]

Acknowledged.

+  InitializeParserAndExpectLiveness(DemuxerStream::LIVENESS_RECORDED);
+  scoped_refptr<DecoderBuffer> buffer = ReadTestDataFile("bear-hevc-frag.mp4");
+  EXPECT_TRUE(AppendDataInPieces(buffer->data(), buffer->data_size(), 512));

[wolenetz, 2015/09/02 20:43:18]

ditto nit: I would think my recent changes would now make this test fail without
some EXPECT_MEDIA_LOG(). Also, please add some parse failure (and associated
EXPECT_MEDIA_LOGs()) case(s).

[wolenetz, 2015/09/02 22:09:24]

See also my comment earlier in this test case.

[servolk, 2015/09/03 00:17:51]

Indeed, the test wasn't running, because ENABLE_HEVC_DEMUXING wasn't defined for
the test target. I've updated the .gyp file (BUILD.gn already handles this by
adding the define into media_config) and seen test failures. Added
EXPECT_MEDIA_LOG to fix the test.

[wolenetz, 2015/09/08 19:53:10]

Acknowledged. Thanks for fixing.

+}
+#endif
+
 TEST_F(MP4StreamParserTest, CENC) {
   // Encrypted test mp4 files have non-zero duration and are treated as
   // recorded streams.
   InitializeParserAndExpectLiveness(DemuxerStream::LIVENESS_RECORDED);
 
   scoped_refptr<DecoderBuffer> buffer =
       ReadTestDataFile("bear-1280x720-v_frag-cenc.mp4");
   EXPECT_MEDIA_LOG(VideoCodecLog("avc1.6401f"));
   EXPECT_TRUE(AppendDataInPieces(buffer->data(), buffer->data_size(), 512));
 }
@@ skipping 15 matching lines @@
   scoped_refptr<DecoderBuffer> buffer =
       ReadTestDataFile("bear-640x360-non_square_pixel-with_pasp.mp4");
 
   EXPECT_MEDIA_LOG(VideoCodecLog("avc1.6401e"));
   EXPECT_TRUE(AppendDataInPieces(buffer->data(), buffer->data_size(), 512));
   EXPECT_EQ(gfx::Size(639, 360), video_decoder_config_.natural_size());
 }
 
 }  // namespace mp4
 }  // namespace media