Topsites become keyedService based.

chrome/browser/thumbnails/thumbnail_service_unittest.cc

Index: chrome/browser/thumbnails/thumbnail_service_unittest.cc
diff --git a/chrome/browser/thumbnails/thumbnail_service_unittest.cc b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
index 32f564c37a3a8b9050ace37b824873a55f2f528f..2b02b6d8ca81480c958bb92d6861bc0e96f43fef 100644
--- a/chrome/browser/thumbnails/thumbnail_service_unittest.cc
+++ b/chrome/browser/thumbnails/thumbnail_service_unittest.cc
@@ -16,9 +16,7 @@ typedef testing::Test ThumbnailServiceTest;
 class MockTopSites : public history::TopSitesImpl {
  public:
   explicit MockTopSites(Profile* profile)
-      : history::TopSitesImpl(profile),
-        capacity_(1) {
-  }
+      : history::TopSitesImpl(profile), capacity_(1) {}
 
   // history::TopSitesImpl overrides.
   bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; }
@@ -57,7 +55,7 @@ class MockProfile : public TestingProfile {
   MockProfile() : mock_top_sites_(new MockTopSites(this)) {

[sdefresne, 2014/12/29 09:48:14]

Remove mock_top_sites_ property.

[Jitu( very slow this week), 2014/12/30 10:09:03]

Done.

   }
 
-  history::TopSites* GetTopSites() override { return mock_top_sites_.get(); }
+  history::TopSites* GetTopSites() { return mock_top_sites_.get(); }

[sdefresne, 2014/12/29 09:48:14]

Remove this method. Instead use TopSitesServiceFactory::SetTestingFactory() to
register a MockTopSites as the TopSites to use for this MockProfile.

You can probably do this in MockProfile constructor:

MockProfile() {
  TopSitesServiceFactory::SetTestingProfile(this, BuildMockTopSites);
}

with BuildMockTopSites defined as:

scoped_refptr<RefcountedKeyedService> BuildMockTopSites(content::BrowserContext*
context) {
  return scoped_refptr<RefcountedKeyedService>(new
MockTopSites(static_cast<Profile*>(context));
}

[Jitu( very slow this week), 2014/12/30 10:09:03]

Done.

 
   void AddKnownURL(const GURL& url, const ThumbnailScore& score) {
     mock_top_sites_->AddKnownURL(url, score);