Topsites become keyedService based.

chrome/browser/thumbnails/thumbnail_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/thumbnails/thumbnail_service_impl.h"
 
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/history/top_sites_impl.h"
 #include "chrome/test/base/testing_profile.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 typedef testing::Test ThumbnailServiceTest;
 
 // A mock version of TopSitesImpl, used for testing
 // ShouldAcquirePageThumbnail().
 class MockTopSites : public history::TopSitesImpl {
  public:
   explicit MockTopSites(Profile* profile)
-      : history::TopSitesImpl(profile),
-        capacity_(1) {
-  }
+      : history::TopSitesImpl(profile), capacity_(1) {}
 
   // history::TopSitesImpl overrides.
   bool IsNonForcedFull() override { return known_url_map_.size() >= capacity_; }
   bool IsForcedFull() override { return false; }
   bool IsKnownURL(const GURL& url) override {
     return known_url_map_.find(url.spec()) != known_url_map_.end();
   }
   bool GetPageThumbnailScore(const GURL& url, ThumbnailScore* score) override {
     std::map<std::string, ThumbnailScore>::const_iterator iter =
         known_url_map_.find(url.spec());
@@ skipping 15 matching lines @@
 
   const size_t capacity_;
   std::map<std::string, ThumbnailScore> known_url_map_;
 
   DISALLOW_COPY_AND_ASSIGN(MockTopSites);
 };
 
 // A mock version of TestingProfile holds MockTopSites.
 class MockProfile : public TestingProfile {
  public:
   MockProfile() : mock_top_sites_(new MockTopSites(this)) {

[sdefresne, 2014/12/29 09:48:14]

Remove mock_top_sites_ property.

[Jitu( very slow this week), 2014/12/30 10:09:03]

Done.

   }
 
-  history::TopSites* GetTopSites() override { return mock_top_sites_.get(); }
+  history::TopSites* GetTopSites() { return mock_top_sites_.get(); }

[sdefresne, 2014/12/29 09:48:14]

Remove this method. Instead use TopSitesServiceFactory::SetTestingFactory() to
register a MockTopSites as the TopSites to use for this MockProfile.

You can probably do this in MockProfile constructor:

MockProfile() {
  TopSitesServiceFactory::SetTestingProfile(this, BuildMockTopSites);
}

with BuildMockTopSites defined as:

scoped_refptr<RefcountedKeyedService> BuildMockTopSites(content::BrowserContext*
context) {
  return scoped_refptr<RefcountedKeyedService>(new
MockTopSites(static_cast<Profile*>(context));
}

[Jitu( very slow this week), 2014/12/30 10:09:03]

Done.

 
   void AddKnownURL(const GURL& url, const ThumbnailScore& score) {
     mock_top_sites_->AddKnownURL(url, score);
   }
 
  private:
   scoped_refptr<MockTopSites> mock_top_sites_;

[sdefresne, 2014/12/29 09:48:14]

Remove this property.

[Jitu( very slow this week), 2014/12/30 10:09:03]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(MockProfile);
 };
 
 TEST_F(ThumbnailServiceTest, ShouldUpdateThumbnail) {
   const GURL kGoodURL("http://www.google.com/");
   const GURL kBadURL("chrome://newtab");
 
   // Set up the mock profile along with mock top sites.
   base::ScopedTempDir temp_dir;
@@ skipping 32 matching lines @@
   good_score.at_top = true;
   good_score.good_clipping = true;
   good_score.boring_score = 0.0;
   good_score.load_completed = true;
   profile.AddKnownURL(kGoodURL, good_score);
 
   // Should be false, as the existing thumbnail is good enough (i.e. don't
   // need to replace the existing thumbnail which is new and good).
   EXPECT_FALSE(thumbnail_service->ShouldAcquirePageThumbnail(kGoodURL));
 }