Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 815883002: Cleanup: Another round of override fixes. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, Nico
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cleanup: Another round of override fixes. BUG=skia:3075 TEST=ninja -C out/Debug TBR=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/752e7eb157f8a18c26b88b7b85eecdbd5549d52e

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : revert include changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -253 lines) Patch
M gm/imageblur2.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M gm/inversepaths.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -3 lines 0 comments Download
M gm/lighting.cpp View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -3 lines 0 comments Download
M gm/patheffects.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/pathfill.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M gm/pathinterior.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathreverse.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/peekpixels.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/points.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/quadpaths.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M gm/rrect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/samplerstress.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M gm/shaderbounds.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M gm/shadertext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/shadertext2.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/spritebitmap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/stringart.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gm/strokefill.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/strokerect.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gm/strokerects.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M gm/strokes.cpp View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M gm/testimagefilters.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M gm/texdata.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tiledscaledbitmap.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M gm/tilemodes.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M gm/verttext.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M gm/verttext2.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M gm/xfermodes.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkAnimate.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkAnimateBase.h View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
M src/animator/SkAnimateSet.h View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayAdd.h View 1 2 3 4 5 1 chunk +7 lines, -7 lines 0 comments Download
M src/animator/SkDisplayApply.h View 1 2 3 4 1 chunk +14 lines, -14 lines 0 comments Download
M src/animator/SkDisplayBounds.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayEvent.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M src/animator/SkDisplayInclude.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayInput.h View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M src/animator/SkDisplayMovie.h View 1 2 3 1 chunk +9 lines, -9 lines 0 comments Download
M src/animator/SkDisplayNumber.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDisplayPost.h View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M src/animator/SkDisplayRandom.h View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayTypes.h View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M src/animator/SkDrawBitmap.h View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -9 lines 0 comments Download
M src/animator/SkDrawColor.h View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -9 lines 0 comments Download
M src/animator/SkDrawGradient.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -4 lines 0 comments Download
M src/animator/SkDrawGroup.h View 1 2 3 4 5 2 chunks +13 lines, -13 lines 0 comments Download
M src/animator/SkDrawMatrix.h View 1 2 3 4 5 1 chunk +10 lines, -10 lines 0 comments Download
M src/animator/SkDrawOval.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawRectangle.h View 1 2 3 4 5 6 2 chunks +9 lines, -9 lines 0 comments Download
M src/animator/SkDump.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkMemberInfo.h View 1 2 3 4 5 6 7 8 1 chunk +11 lines, -11 lines 0 comments Download
M src/animator/SkPostParts.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tfarina
Submitting this set...more coming.
6 years ago (2014-12-20 14:39:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815883002/180001
6 years ago (2014-12-20 14:39:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 815883002-180001 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-20 14:39:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815883002/200001
6 years ago (2014-12-20 14:44:29 UTC) #7
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://skia.googlesource.com/skia/+/752e7eb157f8a18c26b88b7b85eecdbd5549d52e
6 years ago (2014-12-20 14:53:47 UTC) #8
reed1
6 years ago (2014-12-20 17:49:23 UTC) #10
Message was sent while issue was closed.
If you are going to do lots of these, please also remove "virtual" from the
declaration as well.

i.e.

virtual void foo()

becomes

void foo() SK_OVERRIDE

Powered by Google App Engine
This is Rietveld 408576698