Add a simpler key type for scratch resource keys.

Add a simpler key type for scratch resource keys.

BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/7775c85611c734a2af709b3a9c127939a4296c48

[bsalomon, 2014-12-29 22:27:29]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2014-12-30 18:19:52]

lgtm + some clarity suggestions

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKey.h
File include/gpu/GrResourceKey.h (right):

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:88: private:
This enum is a bit mixed. Would it make more sense for kInvalidResourceType be a
separate "static const int" decl, the two k*Idx guys be the real members of the
enum and then kExtraDataCnt be computed from a new "kLastIdx" enum member?

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:92: kHashIdx = 0,
// type and size are folded together into one 32-bit entry ?

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:94: };
// 2 b.c. the stencil and texture resource both require 2 ints of data for their
keys

?

https://codereview.chromium.org/815833004/diff/20001/src/gpu/GrResourceCache2...
File src/gpu/GrResourceCache2.cpp (right):

https://codereview.chromium.org/815833004/diff/20001/src/gpu/GrResourceCache2...
src/gpu/GrResourceCache2.cpp:24: int32_t type = sk_atomic_inc(&gType);
yoda-style ?

[bsalomon, 2014-12-30 18:37:09]

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKey.h
File include/gpu/GrResourceKey.h (right):

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:88: private:
On 2014/12/30 18:19:52, robertphillips wrote:
> This enum is a bit mixed. Would it make more sense for kInvalidResourceType be
a
> separate "static const int" decl, the two k*Idx guys be the real members of
the
> enum and then kExtraDataCnt be computed from a new "kLastIdx" enum member?

Done.

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:92: kHashIdx = 0,
On 2014/12/30 18:19:52, robertphillips wrote:
> // type and size are folded together into one 32-bit entry ?

Done.

https://codereview.chromium.org/815833004/diff/20001/include/gpu/GrResourceKe...
include/gpu/GrResourceKey.h:94: };
On 2014/12/30 18:19:52, robertphillips wrote:
> // 2 b.c. the stencil and texture resource both require 2 ints of data for
their
> keys
> 
> ?

Done.

https://codereview.chromium.org/815833004/diff/20001/src/gpu/GrResourceCache2...
File src/gpu/GrResourceCache2.cpp (right):

https://codereview.chromium.org/815833004/diff/20001/src/gpu/GrResourceCache2...
src/gpu/GrResourceCache2.cpp:24: int32_t type = sk_atomic_inc(&gType);
On 2014/12/30 18:19:52, robertphillips wrote:
> yoda-style ?

Done.

[bsalomon, 2014-12-30 18:38:07]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-12-30 18:38:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815833004/40001

[commit-bot: I haz the power, 2014-12-30 18:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-30 18:40:46]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[bsalomon, 2014-12-30 18:50:03]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-12-30 18:50:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815833004/60001

[commit-bot: I haz the power, 2014-12-30 18:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-30 18:52:26]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[bsalomon, 2014-12-30 20:28:36]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-12-30 20:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815833004/80001

[commit-bot: I haz the power, 2014-12-30 20:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-30 20:30:47]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)

[bsalomon, 2014-12-30 20:41:45]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-12-30 20:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815833004/100001

[commit-bot: I haz the power, 2014-12-30 20:50:56]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/7775c85611c734a2af709b3a9c127939a4296c48