Issue 815653002: Remove global list map of TreeScope to StyleSheetCollection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 815653002: Remove global list map of TreeScope to StyleSheetCollection. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
ojan, eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove global list map of TreeScope to StyleSheetCollection. StyleSheetCollection is tied to TreeScope in lifetime, and should really just be a member of it like the ScopedStyleResolver. Doing this makes the StyleEngine simpler and removes the error prone manual clean up. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1ebe2479c91a2f8c15e01796b62ca45d51f4b134

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -88 lines)			Patch
M	sky/engine/core/dom/StyleEngine.h	View	5 chunks	+2 lines, -27 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.cpp	View	7 chunks	+15 lines, -54 lines	0 comments	Download
M	sky/engine/core/dom/TreeScope.h	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/TreeScope.cpp	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/shadow/ShadowRoot.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years ago (2014-12-18 02:03:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ebe2479c91a2f8c15e01796b62ca45d51f4b134 (presubmit successful).