Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: sky/engine/core/dom/StyleEngine.h

Issue 815653002: Remove global list map of TreeScope to StyleSheetCollection. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/dom/StyleEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/StyleEngine.h
diff --git a/sky/engine/core/dom/StyleEngine.h b/sky/engine/core/dom/StyleEngine.h
index 88a47e8173ec1727c38ac87eaa3604103e0b293c..b44e0335e85082637ea7c8444d8cd095170d5a85 100644
--- a/sky/engine/core/dom/StyleEngine.h
+++ b/sky/engine/core/dom/StyleEngine.h
@@ -30,10 +30,6 @@
#include "sky/engine/core/css/CSSFontSelectorClient.h"
#include "sky/engine/core/css/resolver/StyleResolver.h"
-#include "sky/engine/core/dom/Document.h"
-#include "sky/engine/core/dom/DocumentOrderedList.h"
-#include "sky/engine/core/dom/StyleSheetCollection.h"
-#include "sky/engine/platform/heap/Handle.h"
#include "sky/engine/wtf/FastAllocBase.h"
#include "sky/engine/wtf/ListHashSet.h"
#include "sky/engine/wtf/RefPtr.h"
@@ -45,6 +41,7 @@ namespace blink {
class CSSFontSelector;
class CSSStyleSheet;
+class Document;
class Node;
class RuleFeatureSet;
class StyleRuleFontFace;
@@ -70,8 +67,6 @@ public:
void detachFromDocument();
- const Vector<RefPtr<CSSStyleSheet>>& activeAuthorStyleSheetsFor(TreeScope&);
-
void addStyleSheetCandidateNode(Node*, bool createdByParser);
void removeStyleSheetCandidateNode(Node*, ContainerNode* scopingNode, TreeScope&);
@@ -82,7 +77,6 @@ public:
// FIXME(sky): Remove this and ::first-line.
bool usesFirstLineRules() const { return false; }
- void didRemoveShadowRoot(ShadowRoot*);
void appendActiveAuthorStyleSheets();
StyleResolver* resolver() const
@@ -123,31 +117,12 @@ private:
virtual void fontsNeedUpdate(CSSFontSelector*) override;
private:
- StyleEngine(Document&);
-
- StyleSheetCollection* ensureStyleSheetCollectionFor(TreeScope&);
- StyleSheetCollection* styleSheetCollectionFor(TreeScope&);
+ explicit StyleEngine(Document&);
void createResolver();
- const StyleSheetCollection* documentStyleSheetCollection() const
- {
- return m_documentStyleSheetCollection.get();
- }
-
- StyleSheetCollection* documentStyleSheetCollection()
- {
- return m_documentStyleSheetCollection.get();
- }
-
RawPtr<Document> m_document;
- // TODO(esprehn): Remove special separate collection for document.
- OwnPtr<StyleSheetCollection> m_documentStyleSheetCollection;
-
- typedef HashMap<RawPtr<TreeScope>, OwnPtr<StyleSheetCollection> > StyleSheetCollectionMap;
- StyleSheetCollectionMap m_styleSheetCollectionMap;
-
typedef ListHashSet<TreeScope*, 16> TreeScopeSet;
TreeScopeSet m_activeTreeScopes;
« no previous file with comments | « no previous file | sky/engine/core/dom/StyleEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698