Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 81563002: Removed unused code path. (Closed)

Created:
7 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 1 month ago
Reviewers:
Lei Zhang, gene, Cris Neckar
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Removed unused code path. reuse_existing_data is never set true. It should be removed with https://codereview.chromium.org/26558003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M chrome/browser/printing/print_preview_message_handler.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 4 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/resources/print_preview/preview_generator.js View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/print_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 1 month ago (2013-11-21 20:27:08 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years, 1 month ago (2013-11-21 20:30:21 UTC) #2
Lei Zhang
lgtm
7 years, 1 month ago (2013-11-21 20:52:29 UTC) #3
Cris Neckar
On 2013/11/21 20:52:29, Lei Zhang wrote: > lgtm IPC changes LGTM
7 years, 1 month ago (2013-11-21 22:24:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/81563002/1
7 years, 1 month ago (2013-11-21 22:28:44 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 00:08:35 UTC) #6
Message was sent while issue was closed.
Change committed as 236642

Powered by Google App Engine
This is Rietveld 408576698