Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 26558003: Removed old_print_pages_params_ (Closed)

Created:
7 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 2 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Removed old_print_pages_params_ According UMA old_print_pages_params_ helps in 0.5% of preview request. With current design it's unlikely that preview with sames settings could be requested. JS side already check this. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227717

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -94 lines) Patch
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 9 chunks +17 lines, -92 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 2 months ago (2013-10-08 23:06:50 UTC) #1
gene
lgtm
7 years, 2 months ago (2013-10-08 23:16:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26558003/3001
7 years, 2 months ago (2013-10-08 23:32:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26558003/3001
7 years, 2 months ago (2013-10-09 02:34:40 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-09 03:21:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26558003/24001
7 years, 2 months ago (2013-10-09 05:07:00 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-09 06:38:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26558003/24001
7 years, 2 months ago (2013-10-09 07:46:02 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 10:12:45 UTC) #9
Message was sent while issue was closed.
Change committed as 227717

Powered by Google App Engine
This is Rietveld 408576698