improve precision of gradients

improve precision of gradients (disabled for now)

BUG=skia:2898
TBR=caryclark

Committed: https://skia.googlesource.com/skia/+/caf7e9313b52f78b53ff7d478f9cc41a1f6a85ff

[reed1, 2014-12-18 19:30:09]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-18 19:30:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815623004/1

[commit-bot: I haz the power, 2014-12-18 19:30:44]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-19 01:30 UTC

[reed1, 2014-12-18 19:31:50]

reed@google.com changed reviewers:
+ caryclark@google.com

[reed1, 2014-12-18 19:31:50]

ptal

plan to land as is, and then move the flag into the gypi for chrome and
rebaseilne skia in a separate CL.

[commit-bot: I haz the power, 2014-12-18 19:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-18 19:35:54]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[caryclark, 2014-12-18 19:40:57]

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
File src/effects/gradients/SkClampRange.h (right):

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:16: typedef int64_t SkF32Dot32;
is this different from SkFixed3232 ?

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:18: static inline SkF32Dot32
SkFixedToF32Dot32(SkFixed value) {
looks like SkFixedToFixed3232 ?

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:23: static inline SkF32Dot32
SkScalarToF32Dot32(SkScalar x) {
looks like SkFloatToFixed3232 ?

[reed1, 2014-12-18 20:17:49]

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
File src/effects/gradients/SkClampRange.h (right):

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:16: typedef int64_t SkF32Dot32;
On 2014/12/18 19:40:56, caryclark wrote:
> is this different from SkFixed3232 ?

Done.

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:18: static inline SkF32Dot32
SkFixedToF32Dot32(SkFixed value) {
On 2014/12/18 19:40:56, caryclark wrote:
> looks like SkFixedToFixed3232 ?

Done.

https://codereview.chromium.org/815623004/diff/1/src/effects/gradients/SkClam...
src/effects/gradients/SkClampRange.h:23: static inline SkF32Dot32
SkScalarToF32Dot32(SkScalar x) {
On 2014/12/18 19:40:56, caryclark wrote:
> looks like SkFloatToFixed3232 ?

Done.

[reed1, 2014-12-18 20:28:05]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-18 20:28:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815623004/40001

[commit-bot: I haz the power, 2014-12-18 20:28:39]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-19 02:28 UTC

[reed1, 2014-12-18 20:33:13]

ptal

[reed1, 2014-12-18 20:42:40]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-12-18 20:42:48]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-18 20:42:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815623004/40001

[commit-bot: I haz the power, 2014-12-18 20:43:13]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/caf7e9313b52f78b53ff7d478f9cc41a1f6a85ff