Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 815503002: Add counters for addEventListener/removeEventListener optional arguments (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add counters for addEventListener/removeEventListener optional arguments Per the FIXME in EventTarget.h, making these non-optional per spec has failed once, so add counters to determine if it is now safe or not. BUG=353484 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187434

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M Source/core/events/EventTarget.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 2 chunks +24 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
philipj_slow
rebase
6 years ago (2014-12-17 19:27:25 UTC) #1
philipj_slow
PTAL
6 years ago (2014-12-17 19:34:02 UTC) #3
haraken
LGTM
6 years ago (2014-12-17 23:55:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815503002/20001
6 years ago (2014-12-17 23:56:53 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years ago (2014-12-17 23:57:12 UTC) #8
philipj_slow
rebase
6 years ago (2014-12-18 00:08:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815503002/40001
6 years ago (2014-12-18 06:50:06 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-18 06:53:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187434

Powered by Google App Engine
This is Rietveld 408576698