Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: Source/core/events/EventTarget.cpp

Issue 815503002: Add counters for addEventListener/removeEventListener optional arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/EventTarget.cpp
diff --git a/Source/core/events/EventTarget.cpp b/Source/core/events/EventTarget.cpp
index 62d24a8b6fa8e5290482b8c42a9458b2098147b9..36857b1c455c6793901e4726c9d0823de60b71d1 100644
--- a/Source/core/events/EventTarget.cpp
+++ b/Source/core/events/EventTarget.cpp
@@ -88,6 +88,18 @@ inline LocalDOMWindow* EventTarget::executingWindow()
return 0;
}
+bool EventTarget::addEventListener()
+{
+ UseCounter::count(executionContext(), UseCounter::AddEventListenerNoArguments);
+ return false;
+}
+
+bool EventTarget::addEventListener(const AtomicString& eventType)
+{
+ UseCounter::count(executionContext(), UseCounter::AddEventListenerOneArgument);
+ return false;
+}
+
bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
// FIXME: listener null check should throw TypeError (and be done in
@@ -106,6 +118,18 @@ bool EventTarget::addEventListener(const AtomicString& eventType, PassRefPtr<Eve
return ensureEventTargetData().eventListenerMap.add(eventType, listener, useCapture);
}
+bool EventTarget::removeEventListener()
+{
+ UseCounter::count(executionContext(), UseCounter::RemoveEventListenerNoArguments);
+ return false;
+}
+
+bool EventTarget::removeEventListener(const AtomicString& eventType)
+{
+ UseCounter::count(executionContext(), UseCounter::RemoveEventListenerOneArgument);
+ return false;
+}
+
bool EventTarget::removeEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
{
// FIXME: listener null check should throw TypeError (and be done in
« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698