Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 815363003: FrameView now notifies ScrollCoorinator of changes in its scrollable area set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove extra line Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/Source/core/page/scrolling/ScrollingCoordinator.cpp b/Source/core/page/scrolling/ScrollingCoordinator.cpp
index b86590a19cc5de006a1f84c56aab1321de50ddea..6bde998667c9feb54e252f083aa2917cf156dba9 100644
--- a/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -118,6 +118,15 @@ void ScrollingCoordinator::notifyLayoutUpdated()
m_shouldScrollOnMainThreadDirty = true;
}
+void ScrollingCoordinator::scrollAreaSetDidChange()
+{
+ // Wait until after layout to update.
Ian Vollick 2015/01/07 17:58:03 Why don't we want to set the dirty bit when we nee
majidvp 2015/01/07 19:52:28 A layout also sets the same dirty flag forcing the
Ian Vollick 2015/01/07 19:56:23 Ah, thanks, that makes sense. In that case, could
majidvp 2015/01/12 16:28:27 Done.
+ if (!m_page->deprecatedLocalMainFrame()->view() || m_page->deprecatedLocalMainFrame()->view()->needsLayout())
+ return;
+
+ m_scrollGestureRegionIsDirty = true;
+}
+
void ScrollingCoordinator::updateAfterCompositingChangeIfNeeded()
{
if (!m_page->mainFrame()->isLocalFrame())

Powered by Google App Engine
This is Rietveld 408576698