FrameView now notifies ScrollCoorinator of changes in its scrollable area set

Source/core/page/scrolling/ScrollingCoordinator.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 100 matching lines @@
     }
 }
 
 void ScrollingCoordinator::notifyLayoutUpdated()
 {
     m_scrollGestureRegionIsDirty = true;
     m_touchEventTargetRectsAreDirty = true;
     m_shouldScrollOnMainThreadDirty = true;
 }
 
+void ScrollingCoordinator::scrollAreaSetDidChange()
+{
+    // Wait until after layout to update.

[Ian Vollick, 2015/01/07 17:58:03]

Why don't we want to set the dirty bit when we need a layout? Will a layout
force this to be updated?

[majidvp, 2015/01/07 19:52:28]

A layout also sets the same dirty flag forcing the same update making this one
redundant. (See |ScrollingCoordinator::notifyLayoutUpdate|)
Since a layout may update these scrollable area bounding boxes, I think it makes
sense to wait for layout completion before computing the non-fast scroll
regions.

[Ian Vollick, 2015/01/07 19:56:23]

Ah, thanks, that makes sense. In that case, could you please update the comment
to reassure the future reader that everything's going to be fine after the
layout? :)

[majidvp, 2015/01/12 16:28:27]

Done.

+    if (!m_page->deprecatedLocalMainFrame()->view() || m_page->deprecatedLocalMainFrame()->view()->needsLayout())
+        return;
+
+    m_scrollGestureRegionIsDirty = true;
+}
+
 void ScrollingCoordinator::updateAfterCompositingChangeIfNeeded()
 {
     if (!m_page->mainFrame()->isLocalFrame())
         return;
 
     if (!shouldUpdateAfterCompositingChange())
         return;
 
     TRACE_EVENT0("input", "ScrollingCoordinator::updateAfterCompositingChangeIfNeeded");
 
@@ skipping 867 matching lines @@
     bool frameIsScrollable = frameView && frameView->isScrollable();
     if (frameIsScrollable != m_wasFrameScrollable)
         return true;
 
     if (WebLayer* scrollLayer = frameView ? toWebLayer(frameView->layerForScrolling()) : nullptr)
         return blink::WebSize(frameView->contentsSize()) != scrollLayer->bounds();
     return false;
 }
 
 } // namespace blink