Clean up geolocation code now that it's all upstream.

Clean up geolocation code now that it's all upstream.

GoogleLocationSettingsHelper::Create() is unused and can be deleted.
Likewise for ChromeShellGoogleLocationSettingsHelper. The remaining
classes' names have been shortened to save precious ink.

LocationSettings.java is now always accessed on the UI thread, so it no
longer needs to use ThreadUtils.runOnUiThread().

BUG=448400
Committed: https://crrev.com/e587c6d4dd88d9105c4da5130258f7b9fb09960d
Cr-Commit-Position: refs/heads/master@{#312443}

[newt (away), 2015-01-17 01:44:21]

newt@chromium.org changed reviewers:
+ cjhopman@chromium.org, tedchoc@chromium.org

[newt (away), 2015-01-17 01:44:22]

tedchoc/cjhopman: PTAL chrome_shell.gypi and BUILD.gn. I've deleted the only
files that were part of the libchromeshell_base target... so I'm wondering if I
should delete the target, but two other targets depend on it.

[newt (away), 2015-01-17 01:45:30]

newt@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[newt (away), 2015-01-17 01:45:30]

mvanouwerkerk: PTAL

[Michael van Ouwerkerk, 2015-01-19 12:03:14]

Just some nits.

https://codereview.chromium.org/815343005/diff/1/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/815343005/diff/1/chrome/android/BUILD.gn#newc...
chrome/android/BUILD.gn:171: #sources = [
Did you mean to delete this section?

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
File chrome/browser/android/location_settings_impl.cc (right):

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
chrome/browser/android/location_settings_impl.cc:12: using
base::android::CheckException;
This is unused.

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
chrome/browser/android/location_settings_impl.cc:13: using
base::android::ScopedJavaLocalRef;
This is unused.

[newt (away), 2015-01-20 16:58:52]

https://codereview.chromium.org/815343005/diff/1/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/815343005/diff/1/chrome/android/BUILD.gn#newc...
chrome/android/BUILD.gn:171: #sources = [
On 2015/01/19 12:03:14, Michael van Ouwerkerk wrote:
> Did you mean to delete this section?

Yes, though I'm wondering if I can/should delete this entire build target. After
removing these sources, the target is only used for its list of deps... so it
probably shouldn't be a "static_library" target anymore. Is it OK to have a
target that's just a list of deps and doesn't actually do anything? Or should I
just copy the deps into the two targets that currently depend on
chrome_shell_base?

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
File chrome/browser/android/location_settings_impl.cc (right):

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
chrome/browser/android/location_settings_impl.cc:12: using
base::android::CheckException;
On 2015/01/19 12:03:14, Michael van Ouwerkerk wrote:
> This is unused.

Removed.

https://codereview.chromium.org/815343005/diff/1/chrome/browser/android/locat...
chrome/browser/android/location_settings_impl.cc:13: using
base::android::ScopedJavaLocalRef;
On 2015/01/19 12:03:14, Michael van Ouwerkerk wrote:
> This is unused.

Removed.

[Ted C, 2015-01-20 17:52:19]

lgtm

https://codereview.chromium.org/815343005/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java
(right):

https://codereview.chromium.org/815343005/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java:54:
LocationSettings settings = LocationSettings.getInstance();
Should we have a ThreadUtils.assertOnUiThread() here?

Does this actually matter if it's on the UI thread?

We might want to document it's thread safety-ness here and in the native bits.

https://codereview.chromium.org/815343005/diff/20001/chrome/browser/android/l...
File chrome/browser/android/location_settings.h (right):

https://codereview.chromium.org/815343005/diff/20001/chrome/browser/android/l...
chrome/browser/android/location_settings.h:1: // Copyright 2012 The Chromium
Authors. All rights reserved.
Should all of these be 2015 now?

https://codereview.chromium.org/815343005/diff/20001/chrome/chrome_shell.gypi
File chrome/chrome_shell.gypi (right):

https://codereview.chromium.org/815343005/diff/20001/chrome/chrome_shell.gypi...
chrome/chrome_shell.gypi:24: # TODO(newt): Delete the libchromeshell_base
target?
It does seem odd to have no sources, but it would be worse to have to duplicate
the remainder of this target in the other two in my opinion at least.

[newt (away), 2015-01-20 22:46:08]

https://codereview.chromium.org/815343005/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java
(right):

https://codereview.chromium.org/815343005/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java:54:
LocationSettings settings = LocationSettings.getInstance();
On 2015/01/20 17:52:18, Ted C wrote:
> Should we have a ThreadUtils.assertOnUiThread() here?
> 
> Does this actually matter if it's on the UI thread?
> 
> We might want to document it's thread safety-ness here and in the native bits.

Added ThreadUtils.assertOnUiThread() to LocationSettings.getInstance(), which is
where it really matters.

Also, added a comment about only using on the UI thread.

https://codereview.chromium.org/815343005/diff/20001/chrome/browser/android/l...
File chrome/browser/android/location_settings.h (right):

https://codereview.chromium.org/815343005/diff/20001/chrome/browser/android/l...
chrome/browser/android/location_settings.h:1: // Copyright 2012 The Chromium
Authors. All rights reserved.
On 2015/01/20 17:52:18, Ted C wrote:
> Should all of these be 2015 now?

Done.

[newt (away), 2015-01-20 22:46:48]

Chris, are you happy with chrome/android/BUILD.gn and chrome_shell.gypi?

[cjhopman, 2015-01-20 23:58:03]

yeah, lgtm

[Michael van Ouwerkerk, 2015-01-21 12:11:30]

lgtm

[newt (away), 2015-01-21 17:52:49]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-21 17:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815343005/60001

[commit-bot: I haz the power, 2015-01-21 20:45:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-21 20:46:59]

Patchset 4 (id:??) landed as
https://crrev.com/e587c6d4dd88d9105c4da5130258f7b9fb09960d
Cr-Commit-Position: refs/heads/master@{#312443}