Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/android/BUILD.gn

Issue 815343005: Clean up geolocation code now that it's all upstream. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: renamed IsSystemLocationEnabled -> IsLocationEnabled Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index ecc97345b7d3f60031b5441cfca4aa245d97eade..cce6207fe84980b20b4cb57a6c9d2965a5ecbbf3 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -167,12 +167,7 @@ java_cpp_template("resource_id_javagen") {
}
# GYP: //chrome/chrome_shell.gypi:libchromeshell_base
-static_library("chrome_shell_base") {
- sources = [
- "shell/chrome_shell_google_location_settings_helper.cc",
- "shell/chrome_shell_google_location_settings_helper.h",
- ]
-
+group("chrome_shell_base") {
deps = [
"//chrome/browser/ui",
"//chrome:chrome_android_core",
@@ -181,11 +176,6 @@ static_library("chrome_shell_base") {
"//content/public/app:browser",
"//skia",
]
-
- # Some android targets still depend on --gc-sections to link.
- # TODO: remove --gc-sections for Debug builds (crbug.com/159847).
- ldflags = [ "-Wl,--gc-sections" ]
-
# TODO(GYP):
#[ 'order_profiling!=0', {
#'dependencies': [ '../tools/cygprofile/cygprofile.gyp:cygprofile', ],
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698