Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: components/omnibox/autocomplete_match.cc

Issue 815273002: Remove and deprecate SEARCH_SUGGEST_ANSWER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated with Justin's suggestions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_match.cc
diff --git a/components/omnibox/autocomplete_match.cc b/components/omnibox/autocomplete_match.cc
index efe770e61e932f428515539f673a9737376f9c98..1567237e88cd583837f56fa81378d34bccb850f4 100644
--- a/components/omnibox/autocomplete_match.cc
+++ b/components/omnibox/autocomplete_match.cc
@@ -154,7 +154,6 @@ int AutocompleteMatch::TypeToIcon(Type type) {
IDR_OMNIBOX_SEARCH,
IDR_OMNIBOX_HTTP,
IDR_OMNIBOX_HTTP,
- IDR_OMNIBOX_SEARCH,
groby-ooo-7-16 2014/12/23 20:15:22 Question: Do we still want answers to have a searc
Justin Donnelly 2014/12/23 21:08:40 The icon type will be determined by the existing t
};
COMPILE_ASSERT(arraysize(icons) == AutocompleteMatchType::NUM_TYPES,
icons_array_must_match_type_enum);
@@ -329,8 +328,7 @@ bool AutocompleteMatch::IsSpecializedSearchType(Type type) {
return type == AutocompleteMatchType::SEARCH_SUGGEST_ENTITY ||
type == AutocompleteMatchType::SEARCH_SUGGEST_INFINITE ||
type == AutocompleteMatchType::SEARCH_SUGGEST_PERSONALIZED ||
- type == AutocompleteMatchType::SEARCH_SUGGEST_PROFILE ||
- type == AutocompleteMatchType::SEARCH_SUGGEST_ANSWER;
+ type == AutocompleteMatchType::SEARCH_SUGGEST_PROFILE;
}
// static

Powered by Google App Engine
This is Rietveld 408576698