components/metrics/proto/omnibox_event.proto - Issue 815273002: Remove and deprecate SEARCH_SUGGEST_ANSWER

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 815273002: Remove and deprecate SEARCH_SUGGEST_ANSWER (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated with Justin's suggestions Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/proto/omnibox_event.proto

diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto

index e28d0bdd4d9e4382a977642ecd1ed0f4f82451c6..252f6d8e61026de9156ea00e4244074ee375e36d 100644

--- a/components/metrics/proto/omnibox_event.proto

+++ b/components/metrics/proto/omnibox_event.proto

@@ -217,7 +217,9 @@ message OmniboxEventProto {

// used by Android GSA for on-device

// suggestion logging.

NAVSUGGEST_PERSONALIZED = 21; // A personalized url.

- SEARCH_SUGGEST_ANSWER = 22; // A short result for a suggested search.

+ SEARCH_SUGGEST_ANSWER = 22; // DEPRECATED. Answers no longer have their

+ // own type but instead can be attached to

+ // suggestions of any type.

}

optional ResultType result_type = 2;