Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 814813003: Added test that SurfaceFlinger metrics are calculated on android (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
Reviewers:
ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added test that SurfaceFlinger metrics are calculated on android BUG=

Patch Set 1 #

Patch Set 2 : PLEASE IGNORE: accidentally uploaded to wrong issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+706 lines, -750 lines) Patch
M tools/perf/measurements/smoothness_controller.py View 1 4 chunks +16 lines, -11 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +15 lines, -0 lines 0 comments Download
M tools/perf/measurements/task_execution_time.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/metrics/speedindex_unittest.py View 1 2 chunks +9 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/browser_backend.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 3 chunks +5 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend.py View 1 5 chunks +28 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 1 3 chunks +6 lines, -56 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 3 chunks +17 lines, -13 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_timeline.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 2 chunks +17 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py View 1 3 chunks +5 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/trace_profiler.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_controller_backend.py View 1 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/results/json_output_formatter_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results_unittest.py View 1 2 chunks +3 lines, -5 lines 0 comments Download
D tools/telemetry/telemetry/timeline/empty_timeline_data_importer.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D tools/telemetry/telemetry/timeline/empty_timeline_data_importer_unittest.py View 1 1 chunk +0 lines, -33 lines 0 comments Download
M tools/telemetry/telemetry/timeline/importer.py View 1 1 chunk +5 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_importer.py View 1 1 chunk +10 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/timeline/inspector_importer_unittest.py View 1 3 chunks +10 lines, -9 lines 0 comments Download
D tools/telemetry/telemetry/timeline/inspector_timeline_data.py View 1 1 chunk +0 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 1 6 chunks +43 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model_unittest.py View 1 1 chunk +14 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/timeline/surface_flinger_importer.py View 1 1 chunk +7 lines, -10 lines 0 comments Download
D tools/telemetry/telemetry/timeline/surface_flinger_timeline_data.py View 1 1 chunk +0 lines, -29 lines 0 comments Download
A tools/telemetry/telemetry/timeline/tab_id_importer.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/timeline/tab_id_importer_unittest.py View 1 1 chunk +72 lines, -0 lines 0 comments Download
D tools/telemetry/telemetry/timeline/timeline_data.py View 1 1 chunk +0 lines, -16 lines 0 comments Download
A tools/telemetry/telemetry/timeline/trace_data.py View 1 1 chunk +183 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/timeline/trace_data_unittest.py View 1 1 chunk +80 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer.py View 1 3 chunks +9 lines, -100 lines 0 comments Download
M tools/telemetry/telemetry/timeline/trace_event_importer_unittest.py View 1 35 chunks +66 lines, -261 lines 0 comments Download
D tools/telemetry/telemetry/timeline/tracing_timeline_data.py View 1 1 chunk +0 lines, -23 lines 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 3 chunks +7 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/trace_unittest.py View 1 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sullivan
6 years ago (2014-12-19 22:57:40 UTC) #2
sullivan
I ended up adding this test in issue 805463002 because it caught bugs in my ...
6 years ago (2014-12-22 20:43:25 UTC) #3
ernstm
6 years ago (2014-12-22 21:19:12 UTC) #4
Message was sent while issue was closed. 
On 2014/12/22 20:43:25, sullivan wrote:
> I ended up adding this test in issue 805463002 because it caught bugs in my
> code. I am closing this issue.
> 
> Please feel free to comment about improvements to the test and I will
implement
> them in a follow-up.
> 
> Apologies for dumping the unrelated patch 2 to this issue by accident.

You should check all SurfaceFlinger metrics: avg_surface_fps, jank_count,
frame_lengths, and max_frame_delay
(https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...)

Powered by Google App Engine
This is Rietveld 408576698