tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py - Issue 814813003: Added test that SurfaceFlinger metrics are calculated on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

Issue 814813003: Added test that SurfaceFlinger metrics are calculated on android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: PLEASE IGNORE: accidentally uploaded to wrong issue Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/profiler/strace_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

index 0d3d668dca5a909b65735c9c1580d125a4602027..3245014eecbe38fd2d0d82994113ad9e8c42c085 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py

@@ -11,6 +11,7 @@ from telemetry.core import util

from telemetry.core.backends.chrome import android_browser_finder

from telemetry.core.platform import profiler

from telemetry.core.platform import tracing_options

+from telemetry.timeline import trace_data as trace_data_module

_SYSTRACE_CATEGORIES = [

'gfx',

@@ -56,7 +57,9 @@ class AndroidSystraceProfiler(profiler.Profiler):

def CollectProfile(self):

self._profiler.communicate(input='\n')

- trace_result = self._browser_backend.StopTracing()

+ trace_result_builder = trace_data_module.TraceDataBuilder()

+ self._browser_backend.StopTracing(trace_result_builder)

+ trace_result = trace_result_builder.AsData()

trace_file = StringIO.StringIO()

trace_result.Serialize(trace_file)