Issue 814713002: Null check StyleEngine in ~ShadowRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 814713002: Null check StyleEngine in ~ShadowRoot. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
ojan, eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Null check StyleEngine in ~ShadowRoot. Not all documents have a StyleEngine, only displayed (active) ones. We need a null check to avoid crashing in the ShadowRoot destructor. BUG=443423 R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d1595422335b4b57386f48bedf7b1007d8e8f6a6

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/engine/core/dom/shadow/ShadowRoot.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years ago (2014-12-18 01:20:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d1595422335b4b57386f48bedf7b1007d8e8f6a6 (presubmit successful).