sky/engine/core/dom/shadow/ShadowRoot.cpp - Issue 814713002: Null check StyleEngine in ~ShadowRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/shadow/ShadowRoot.cpp

Issue 814713002: Null check StyleEngine in ~ShadowRoot. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/shadow/ShadowRoot.cpp

diff --git a/sky/engine/core/dom/shadow/ShadowRoot.cpp b/sky/engine/core/dom/shadow/ShadowRoot.cpp

index 80d5b8229f8db809fc01c3ff20dc5fb3be80bc3e..239764bc7b178e1b9743bb32ce715d4e9619ec04 100644

--- a/sky/engine/core/dom/shadow/ShadowRoot.cpp

+++ b/sky/engine/core/dom/shadow/ShadowRoot.cpp

@@ -56,7 +56,8 @@ ShadowRoot::ShadowRoot(Document& document)

ShadowRoot::~ShadowRoot()

{

- document().styleEngine()->didRemoveShadowRoot(this);

+ if (StyleEngine* styleEngine = document().styleEngine())

+ styleEngine->didRemoveShadowRoot(this);

// We cannot let ContainerNode destructor call willBeDeletedFromDocument()

// for this ShadowRoot instance because TreeScope destructor

« no previous file with comments | « no previous file | no next file » | no next file with comments »