Issue 814633002: Chromecast: generate IPC ParamTraits implementations for enums.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 814633002: Chromecast: generate IPC ParamTraits implementations for enums. (Closed)

Created:
6 years ago by gunsch

Modified:
6 years ago

Reviewers:
lcwu1

CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Chromecast: generate IPC ParamTraits implementations for enums. Currently the implementations are not being linked in, but since they're dead code at the moment it wasn't yet detectable. R=lcwu@chromium.org BUG= Committed: https://crrev.com/6e56a0c055ab2afd24a35c99db3b28c8b5fad84a Cr-Commit-Position: refs/heads/master@{#308931}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -10 lines)			Patch
M	chromecast/common/media/cma_message_generator.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chromecast/common/media/cma_param_traits.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chromecast/common/media/cma_param_traits_macros.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814633002/1

6 years ago (2014-12-18 01:57:13 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-18 03:07:56 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6e56a0c055ab2afd24a35c99db3b28c8b5fad84a
Cr-Commit-Position: refs/heads/master@{#308931}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages