Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chromecast/common/media/cma_param_traits.cc

Issue 814633002: Chromecast: generate IPC ParamTraits implementations for enums. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/common/media/cma_message_generator.cc ('k') | chromecast/common/media/cma_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/common/media/cma_param_traits.cc
diff --git a/chromecast/common/media/cma_param_traits.cc b/chromecast/common/media/cma_param_traits.cc
index dc8695920e8daa49f1847ef5bf86f16242c42d63..33accb04672e6049f929050ddfe58b2583081071 100644
--- a/chromecast/common/media/cma_param_traits.cc
+++ b/chromecast/common/media/cma_param_traits.cc
@@ -13,6 +13,19 @@
#include "media/base/video_decoder_config.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
+// Note(gunsch): these are currently defined in content/, but not declared in
+// content/public/. These headers need to be forward-declared for chromecast/,
+// but without new implementations linked in.
+// The correct long-term fix is to use Mojo instead of the content/ IPCs.
+IPC_ENUM_TRAITS_MIN_MAX_VALUE(media::ChannelLayout,
+ media::ChannelLayout::CHANNEL_LAYOUT_NONE,
+ media::ChannelLayout::CHANNEL_LAYOUT_MAX)
+IPC_ENUM_TRAITS_MIN_MAX_VALUE(media::VideoCodecProfile,
+ media::VIDEO_CODEC_PROFILE_MIN,
+ media::VIDEO_CODEC_PROFILE_MAX)
+IPC_ENUM_TRAITS_MAX_VALUE(media::VideoFrame::Format,
+ media::VideoFrame::FORMAT_MAX)
+
namespace IPC {
void ParamTraits<media::AudioDecoderConfig>::Write(
« no previous file with comments | « chromecast/common/media/cma_message_generator.cc ('k') | chromecast/common/media/cma_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698