Split EmbeddedWorkerDevToolsAgentHost into two for Shared- and ServiceWorker

Split EmbeddedWorkerDevToolsAgentHost into two for Shared- and ServiceWorker

Refactoring only, no changes in the code logic.

The code around Matches() is a bit awkward for now, I'm
going to clean up them too in a followup CL.

BUG=443470
Committed: https://crrev.com/c97aaa143edd02f4e87f0197315fb60c2388c50c
Cr-Commit-Position: refs/heads/master@{#308970}

[kinuko, 2014-12-18 04:07:50]

Patchset #1 (id:1) has been deleted

[kinuko, 2014-12-18 04:16:36]

kinuko@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kinuko, 2014-12-18 04:18:26]

kinuko@chromium.org changed reviewers:
+ horo@chromium.org

[kinuko, 2014-12-18 04:29:00]

Refactoring only, follow-up CL for
https://codereview.chromium.org/761923004/#msg18.
(Planning to have at least one more follow-up CL)

pfeldman@, horo@: could you take a look?

Thanks,

[horo, 2014-12-18 05:55:56]

lgtm with nits

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
File content/browser/devtools/embedded_worker_devtools_agent_host.h (right):

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
content/browser/devtools/embedded_worker_devtools_agent_host.h:24:
EmbeddedWorkerDevToolsAgentHost(WorkerId worker_id,
remove this

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
File content/browser/devtools/shared_worker_devtools_agent_host.cc (right):

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
content/browser/devtools/shared_worker_devtools_agent_host.cc:32: return
shared_worker_ ? TYPE_SHARED_WORKER : TYPE_SERVICE_WORKER;
return TYPE_SHARED_WORKER;

[kinuko, 2014-12-18 06:24:54]

Good catches, thanks.

pfeldman@: mind doing an owner's review (you or someone in your team)?

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
File content/browser/devtools/embedded_worker_devtools_agent_host.h (right):

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
content/browser/devtools/embedded_worker_devtools_agent_host.h:24:
EmbeddedWorkerDevToolsAgentHost(WorkerId worker_id,
On 2014/12/18 05:55:56, horo wrote:
> remove this

Done.

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
File content/browser/devtools/shared_worker_devtools_agent_host.cc (right):

https://codereview.chromium.org/814513003/diff/40001/content/browser/devtools...
content/browser/devtools/shared_worker_devtools_agent_host.cc:32: return
shared_worker_ ? TYPE_SHARED_WORKER : TYPE_SERVICE_WORKER;
On 2014/12/18 05:55:56, horo wrote:
> return TYPE_SHARED_WORKER;

Done.

[pfeldman, 2014-12-18 06:29:35]

lgtm

[kinuko, 2014-12-18 06:42:12]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2014-12-18 06:43:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/814513003/60001

[commit-bot: I haz the power, 2014-12-18 08:16:00]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-12-18 08:16:59]

Patchset 3 (id:??) landed as
https://crrev.com/c97aaa143edd02f4e87f0197315fb60c2388c50c
Cr-Commit-Position: refs/heads/master@{#308970}