content/browser/devtools/embedded_worker_devtools_manager.cc - Issue 814513003: Split EmbeddedWorkerDevToolsAgentHost into two for Shared- and ServiceWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/embedded_worker_devtools_manager.cc

Issue 814513003: Split EmbeddedWorkerDevToolsAgentHost into two for Shared- and ServiceWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed horo's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/embedded_worker_devtools_agent_host.cc ('k') | content/browser/devtools/service_worker_devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/embedded_worker_devtools_manager.cc

diff --git a/content/browser/devtools/embedded_worker_devtools_manager.cc b/content/browser/devtools/embedded_worker_devtools_manager.cc

index aad356cdecc7087aea587535550c6e32623e7b77..f51cd2b88ed9d5ccf0a3c0d9bf60be876230668b 100644

--- a/content/browser/devtools/embedded_worker_devtools_manager.cc

+++ b/content/browser/devtools/embedded_worker_devtools_manager.cc

@@ -5,8 +5,9 @@

#include "content/browser/devtools/embedded_worker_devtools_manager.h"

#include "content/browser/devtools/devtools_manager.h"

-#include "content/browser/devtools/embedded_worker_devtools_agent_host.h"

#include "content/browser/devtools/ipc_devtools_agent_host.h"

+#include "content/browser/devtools/service_worker_devtools_agent_host.h"

+#include "content/browser/devtools/shared_worker_devtools_agent_host.h"

#include "content/browser/shared_worker/shared_worker_instance.h"

#include "content/common/devtools_messages.h"

#include "content/public/browser/browser_thread.h"

@@ -102,7 +103,7 @@ bool EmbeddedWorkerDevToolsManager::SharedWorkerCreated(

const WorkerId id(worker_process_id, worker_route_id);

AgentHostMap::iterator it = FindExistingSharedWorkerAgentHost(instance);

if (it == workers_.end()) {

- workers_[id] = new EmbeddedWorkerDevToolsAgentHost(id, instance);

+ workers_[id] = new SharedWorkerDevToolsAgentHost(id, instance);

DevToolsManager::GetInstance()->AgentHostChanged(workers_[id]);

return false;

}

@@ -119,7 +120,7 @@ bool EmbeddedWorkerDevToolsManager::ServiceWorkerCreated(

AgentHostMap::iterator it =

FindExistingServiceWorkerAgentHost(service_worker_id);

if (it == workers_.end()) {

- workers_[id] = new EmbeddedWorkerDevToolsAgentHost(

+ workers_[id] = new ServiceWorkerDevToolsAgentHost(

id, service_worker_id, debug_service_worker_on_start_);

DevToolsManager::GetInstance()->AgentHostChanged(workers_[id]);

return debug_service_worker_on_start_;