Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 814353002: Subzero: Convert NULL->nullptr. (Closed)

Created:
6 years ago by Jim Stichnoth
Modified:
6 years ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Convert NULL->nullptr. This is limited to the src directory, and not (yet) the crosstest directory. BUG= none R=jfb@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ae953202e3a647dde1c0778432a3e92dd2eff3f2

Patch Set 1 #

Patch Set 2 : Revert crosstest whitespace changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -179 lines) Patch
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/IceCfgNode.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceInst.h View 4 chunks +5 lines, -4 lines 0 comments Download
M src/IceInst.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M src/IceInstX8632.h View 6 chunks +10 lines, -10 lines 0 comments Download
M src/IceInstX8632.cpp View 7 chunks +24 lines, -24 lines 0 comments Download
M src/IceIntrinsics.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceLiveness.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceOperand.h View 9 chunks +12 lines, -12 lines 0 comments Download
M src/IceOperand.cpp View 11 chunks +16 lines, -16 lines 0 comments Download
M src/IceRegAlloc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLowering.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceTargetLowering.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 54 chunks +70 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
6 years ago (2014-12-20 01:11:13 UTC) #2
JF
lgtm
6 years ago (2014-12-20 07:31:49 UTC) #3
Jim Stichnoth
6 years ago (2014-12-20 14:17:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae953202e3a647dde1c0778432a3e92dd2eff3f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698