Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 814313002: Revert of Use template specialization to generate WindowProperty code (Closed)

Created:
6 years ago by Chirantan Ekbote
Modified:
6 years ago
CC:
chromium-reviews, tfarina, sadrul, sky, oshima, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use template specialization to generate WindowProperty code (patchset #8 id:330001 of https://codereview.chromium.org/801953002/) Reason for revert: This is breaking chrome on chrome os builds: In file included from ../../ui/aura/client/screen_position_client.cc:7:0: ../../ui/aura/window_property.h:115:58: error: specialization of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' in different namespace [-fpermissive] const aura::WindowProperty<T >* property, T value) { \ ^ ../../ui/aura/window_property.h:127:5: note: in expansion of macro 'DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE' DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(, T) ^ ../../ui/aura/client/screen_position_client.cc:9:1: note: in expansion of macro 'DECLARE_WINDOW_PROPERTY_TYPE' DECLARE_WINDOW_PROPERTY_TYPE(aura::client::ScreenPositionClient*) ^ In file included from ../../ui/aura/client/screen_position_client.h:9:0, from ../../ui/aura/client/screen_position_client.cc:5: ../../ui/aura/window.h:297:8: error: from definition of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' [-fpermissive] void SetProperty(const WindowProperty<T>* property, T value); ^ Original issue's description: > Use template specialization to generate WindowProperty code. > > They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). > > BUG=None > R=sadrul@chromium.org > > Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73 > Cr-Commit-Position: refs/heads/master@{#309252} TBR=sadrul@chromium.org,sky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Seems like nobody is around. LGTM. I'm broken by this as well. Committed: https://crrev.com/933d4da4fb425cb57480445f21c66bcfb95dcebe Cr-Commit-Position: refs/heads/master@{#309285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -93 lines) Patch
M ash/shelf/shelf_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/touch/touch_uma.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/window_properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/extensions/athena_constrained_window_views_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/screen/modal_window_controller.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M athena/util/fill_layout_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M athena/wm/window_list_provider_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/client/focus_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/aura/window_property.h View 2 chunks +38 lines, -50 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +22 lines, -23 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/wm/core/transient_window_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Chirantan Ekbote
Created Revert of Use template specialization to generate WindowProperty code
6 years ago (2014-12-19 22:23:42 UTC) #1
Chirantan Ekbote
I'm not a committer so I'll still need an lgtm for this revert.
6 years ago (2014-12-19 22:25:11 UTC) #2
Steve McKay
LGTM. I'm broken by this as well.
6 years ago (2014-12-19 22:47:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814313002/1
6 years ago (2014-12-19 22:49:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 22:50:36 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-19 22:51:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/933d4da4fb425cb57480445f21c66bcfb95dcebe
Cr-Commit-Position: refs/heads/master@{#309285}

Powered by Google App Engine
This is Rietveld 408576698