Issue 8143010: Revert 102834 - Revert 102806 - [Sync Setup UI] String changes. "Sync" -> "Sign In" and others.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8143010: Revert 102834 - Revert 102806 - [Sync Setup UI] String changes. "Sync" -> "Sign In" and others. (Closed)

Created:
9 years, 2 months ago by binji

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, binji

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 102834 - Revert 102806 - [Sync Setup UI] String changes. "Sync" -> "Sign In" and others. I was asked to revert this by a sheriff on a failing mac test, but I've successfully retried, so I think it was flake. BUG=93176, 97523 TEST=manual Review URL: http://codereview.chromium.org/7977029 TBR=binji@chromium.org Review URL: http://codereview.chromium.org/8028049 TBR=binji@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104047

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -23 lines)			Patch
M	chrome/app/generated_resources.grd	View	4 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/personal_options_handler.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/stop_syncing_handler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8143010/1

9 years, 2 months ago (2011-10-04 23:27:58 UTC) #2

Change committed as 104047