Issue 7977029: [Sync Setup UI] String changes. "Sync" -> "Sign In" and others.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7977029: [Sync Setup UI] String changes. "Sync" -> "Sign In" and others. (Closed)

Created:
9 years, 3 months ago by binji

Modified:
9 years, 2 months ago

Reviewers:
csilv, commit-bot: I haz the power

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync Setup UI] String changes. "Sync" -> "Sign In" and others. BUG=93176, 97523 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102806

Patch Set 3 : " #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -23 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	4 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/resources/options/personal_options.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/personal_options_handler.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/stop_syncing_handler.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

LGTM w/ typo fix. http://codereview.chromium.org/7977029/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/7977029/diff/1/chrome/app/generated_resources.grd#newcode9613 chrome/app/generated_resources.grd:9613: Sign into <ph name="PRODUCT_NAME">$1<ex>Chrome</ex></ph> with ...

9 years, 3 months ago (2011-09-21 21:13:56 UTC) #2

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/7977029/5001

9 years, 2 months ago (2011-09-26 18:23:40 UTC) #3

Change committed as 102806

Expand Messages | Collapse Messages

Issue 7977029: [Sync Setup UI] String changes. "Sync" -> "Sign In" and others. (Closed)

Description

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Messages