Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: src/IceGlobalContext.cpp

Issue 814163004: Subzero: Remove the GlobalContext::GlobalDeclarations vector. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove unused GlobalContext args Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceGlobalContext.h ('k') | src/IceGlobalInits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceGlobalContext.cpp
diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp
index 2b143f70561592f2e8c3bc03f8f920415fef279d..74dfb9ecebd7c29797960fd13498721b6fa31dc7 100644
--- a/src/IceGlobalContext.cpp
+++ b/src/IceGlobalContext.cpp
@@ -314,7 +314,6 @@ IceString GlobalContext::mangleName(const IceString &Name) const {
}
GlobalContext::~GlobalContext() {
- llvm::DeleteContainerPointers(GlobalDeclarations);
llvm::DeleteContainerPointers(AllThreadContexts);
}
@@ -448,29 +447,6 @@ ConstantList GlobalContext::getConstantPool(Type Ty) {
llvm_unreachable("Unknown type");
}
-// No locking because only the bitcode parser thread calls it.
-// TODO(stichnot,kschimpf): GlobalContext::GlobalDeclarations actually
-// seems to be unused. If so, remove that field and this method.
-FunctionDeclaration *
-GlobalContext::newFunctionDeclaration(const FuncSigType *Signature,
- unsigned CallingConv, unsigned Linkage,
- bool IsProto) {
- FunctionDeclaration *Func = new FunctionDeclaration(
- *Signature, static_cast<llvm::CallingConv::ID>(CallingConv),
- static_cast<llvm::GlobalValue::LinkageTypes>(Linkage), IsProto);
- GlobalDeclarations.push_back(Func);
- return Func;
-}
-
-// No locking because only the bitcode parser thread calls it.
-// TODO(stichnot,kschimpf): GlobalContext::GlobalDeclarations actually
-// seems to be unused. If so, remove that field and this method.
-VariableDeclaration *GlobalContext::newVariableDeclaration() {
- VariableDeclaration *Var = new VariableDeclaration();
- GlobalDeclarations.push_back(Var);
- return Var;
-}
-
TimerStackIdT GlobalContext::newTimerStackID(const IceString &Name) {
if (!ALLOW_DUMP)
return 0;
« no previous file with comments | « src/IceGlobalContext.h ('k') | src/IceGlobalInits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698