Subzero: Remove the GlobalContext::GlobalDeclarations vector.

src/IceGlobalContext.cpp

 //===- subzero/src/IceGlobalContext.cpp - Global context defs -------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file defines aspects of the compilation that persist across
@@ skipping 296 matching lines @@
     incrementSubstitutions(NewName);
     return NewName.data();
   }
 
   // Transform bar ==> Prefixbar
   //                   ^^^^^^
   return getTestPrefix() + Name;
 }
 
 GlobalContext::~GlobalContext() {
-  llvm::DeleteContainerPointers(GlobalDeclarations);
   llvm::DeleteContainerPointers(AllThreadContexts);
 }
 
 // TODO(stichnot): Consider adding thread-local caches of constant
 // pool entries to reduce contention.
 
 // All locking is done by the getConstantInt[0-9]+() target function.
 Constant *GlobalContext::getConstantInt(Type Ty, int64_t Value) {
   switch (Ty) {
   case IceType_i1:
@@ skipping 113 matching lines @@
     BaseOS << "Unsupported constant type: " << Ty;
     llvm_unreachable(BaseOS.str().c_str());
   } break;
   case IceType_void:
   case IceType_NUM:
     break;
   }
   llvm_unreachable("Unknown type");
 }
 
-// No locking because only the bitcode parser thread calls it.
-// TODO(stichnot,kschimpf): GlobalContext::GlobalDeclarations actually
-// seems to be unused.  If so, remove that field and this method.
-FunctionDeclaration *
-GlobalContext::newFunctionDeclaration(const FuncSigType *Signature,
-                                      unsigned CallingConv, unsigned Linkage,
-                                      bool IsProto) {
-  FunctionDeclaration *Func = new FunctionDeclaration(
-      *Signature, static_cast<llvm::CallingConv::ID>(CallingConv),
-      static_cast<llvm::GlobalValue::LinkageTypes>(Linkage), IsProto);
-  GlobalDeclarations.push_back(Func);
-  return Func;
-}
-
-// No locking because only the bitcode parser thread calls it.
-// TODO(stichnot,kschimpf): GlobalContext::GlobalDeclarations actually
-// seems to be unused.  If so, remove that field and this method.
-VariableDeclaration *GlobalContext::newVariableDeclaration() {
-  VariableDeclaration *Var = new VariableDeclaration();
-  GlobalDeclarations.push_back(Var);
-  return Var;
-}
-
 TimerStackIdT GlobalContext::newTimerStackID(const IceString &Name) {
   if (!ALLOW_DUMP)
     return 0;
   auto Timers = getTimers();
   TimerStackIdT NewID = Timers->size();
   Timers->push_back(TimerStack(Name));
   return NewID;
 }
 
 TimerIdT GlobalContext::getTimerID(TimerStackIdT StackID,
@@ skipping 54 matching lines @@
   if (ALLOW_DUMP) {
     Active = Func->getFocusedTiming() || Ctx->getFlags().SubzeroTimingEnabled;
     if (Active)
       Ctx->pushTimer(ID);
   }
 }
 
 thread_local GlobalContext::ThreadContext *GlobalContext::TLS;
 
 } // end of namespace Ice