Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 814163004: Subzero: Remove the GlobalContext::GlobalDeclarations vector. (Closed)

Created:
5 years, 11 months ago by Jim Stichnoth
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Remove the GlobalContext::GlobalDeclarations vector. Elements were added to this vector, but never inspected, so it is essentially a useless field. Plus, the removal allows us to remove a couple of friend declarations. BUG=none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a086b9135f3a492100ab349a5dccad8a1599f4bd

Patch Set 1 #

Patch Set 2 : Remove unused GlobalContext args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -60 lines) Patch
M src/IceConverter.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceGlobalContext.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +0 lines, -24 lines 0 comments Download
M src/IceGlobalInits.h View 1 3 chunks +2 lines, -8 lines 0 comments Download
M src/IceGlobalInits.cpp View 1 2 chunks +6 lines, -8 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jim Stichnoth
5 years, 11 months ago (2015-01-20 21:58:03 UTC) #2
Karl
lgtm
5 years, 11 months ago (2015-01-20 22:00:08 UTC) #3
Jim Stichnoth
PTAL. For the first patchset, I didn't notice the new compiler warnings from the fact ...
5 years, 11 months ago (2015-01-20 22:07:37 UTC) #4
Karl
lgtm
5 years, 11 months ago (2015-01-20 22:34:42 UTC) #5
Jim Stichnoth
5 years, 11 months ago (2015-01-20 22:54:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a086b9135f3a492100ab349a5dccad8a1599f4bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698