Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 814123006: Revert of Implemented consumer management unenrollment. (Closed)

Created:
5 years, 11 months ago by ricow1
Modified:
5 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dcpm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implemented consumer management unenrollment. (patchset #15 id:300001 of https://codereview.chromium.org/751703003/) Reason for revert: This seems to be leaking, see: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29&number=5886 Original issue's description: > Implemented consumer management unenrollment. > > To implement this feature: > - Added ConsumerUnenrollmentHandler and ConsumerUnenrollmentHandlerFactory. > - Added DevcieCloudPolicyManagerChromeOS::Unregister() and Disconnect(). > - Added CloudPolicyService::Unregister(). > - Added unenrollment related stages in ConsumerManagementStage. > - Extended ConsumerManagementNotification to show unenroll notifications. > > Also, the device cloud policy initializer is restarted after the unenrollment > so that we can implement reboot-free enrollment in the future. To implement > this feature: > - Added OnDeviceCloudPolicyManagerDisconnected(). > - Added BrowserPolicyConnectChromeOS::RestartDeviceCloudPolicyInitializer() > - Fixed the initiailzer so that it uses ConsumerManagementService to check if > the device is consumer-managed rather using DeviceCloudPolicyStore, which > doesn't load policies for consumer-managed devices. > > BUG=chromium:353050 > TEST=unit_tests > > Committed: https://crrev.com/051ed4f27b9361534e25311ad1987f30335faa16 > Cr-Commit-Position: refs/heads/master@{#311643} TBR=bartfab@chromium.org,mnissler@chromium.org,ygorshenin@chromium.org,stevenjb@chromium.org,stevenjb@google.com,davidyu@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:353050 Committed: https://crrev.com/96bd0b01b6d0e993be38a06b1c0af69ae44f6acb Cr-Commit-Position: refs/heads/master@{#311646}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -941 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/chromeos/ownership/fake_owner_settings_service.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/chromeos/ownership/fake_owner_settings_service.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h View 3 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc View 4 chunks +17 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_notifier.h View 2 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_notifier.cc View 3 chunks +41 lines, -64 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_notifier_unittest.cc View 2 chunks +2 lines, -53 lines 0 comments Download
M chrome/browser/chromeos/policy/consumer_management_service_unittest.cc View 1 chunk +2 lines, -9 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_factory.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/chromeos/policy/consumer_unenrollment_handler_unittest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 1 chunk +41 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 5 chunks +3 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/policy/fake_device_cloud_policy_manager.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/consumer_management_handler.cc View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service.h View 4 chunks +1 line, -22 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service.cc View 6 chunks +2 lines, -31 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_service_unittest.cc View 3 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
Created Revert of Implemented consumer management unenrollment.
5 years, 11 months ago (2015-01-15 10:03:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814123006/1
5 years, 11 months ago (2015-01-15 10:04:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 10:05:47 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 10:06:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96bd0b01b6d0e993be38a06b1c0af69ae44f6acb
Cr-Commit-Position: refs/heads/master@{#311646}

Powered by Google App Engine
This is Rietveld 408576698