Notify main-thread of top controls state changes

Notify main-thread of top controls state/height changes instead of CC.

Compositor receives these values from blink via WebLayerTreeView API. This way
the main-thread can show/hide top controls without violating its constraints
and it has the option in future to change these directly without notifying CC.

Top controls is self-animated to completion is also triggered  when a main-
thread fling ends.

Depends on CL: http://crrev.com/893683003

BUG=333143
Committed: https://crrev.com/fb80e434a19801b56124a8175bc03b9844f87db5
Cr-Commit-Position: refs/heads/master@{#317581}

[majidvp, 2015-02-11 22:58:22]

majidvp@chromium.org changed reviewers:
+ aelias@chromium.org

[aelias_OOO_until_Jul13, 2015-02-12 00:45:29]

https://codereview.chromium.org/814083004/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/814083004/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:938: ScrollEnd();
Not sure we want the "ClearCurrentlyScrollingLayer();" behavior of ScrollEnd. 
There could also be other things added there later that are also incompatible
with main-thread flings -- there's a strong expectation that ScrollEnd matches
ScrollBegin.  I'd suggest adding a new method
TopControlsManager::MainThreadHasStoppedFlinging that just calls
StartAnimationIfNecessary.

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
content/renderer/render_view_impl_android.cc:64:
compositor_->UpdateTopControlsState(ContentToCc(constraints),
Instead of having the plumbing fork here, let's plumb the current and animate
back from Blink via WebLayerTreeView API.  That will leave the option open in
the future of things like setting the "current" directly on the main thread
without notifying CC.

[majidvp, 2015-02-12 13:51:48]

https://codereview.chromium.org/814083004/diff/20001/cc/trees/layer_tree_host...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/814083004/diff/20001/cc/trees/layer_tree_host...
cc/trees/layer_tree_host_impl.cc:938: ScrollEnd();
On 2015/02/12 00:45:29, aelias wrote:
> Not sure we want the "ClearCurrentlyScrollingLayer();" behavior of ScrollEnd. 
> There could also be other things added there later that are also incompatible
> with main-thread flings -- there's a strong expectation that ScrollEnd matches
> ScrollBegin.  I'd suggest adding a new method
> TopControlsManager::MainThreadHasStoppedFlinging that just calls
> StartAnimationIfNecessary.

Acknowledged.

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
content/renderer/render_view_impl_android.cc:64:
compositor_->UpdateTopControlsState(ContentToCc(constraints),
On 2015/02/12 00:45:29, aelias wrote:
> Instead of having the plumbing fork here, let's plumb the current and animate
> back from Blink via WebLayerTreeView API.  That will leave the option open in
> the future of things like setting the "current" directly on the main thread
> without notifying CC.

That sounds good. In which case to be consistent I suggest we do the same for
TopContrtolsHeight, and TopControlsShrinkBlinkSize and plumb them from Blink to
CC via WebLayerTreeView API and remove it from here:
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

[aelias_OOO_until_Jul13, 2015-02-12 19:24:55]

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl_android.cc (right):

https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
content/renderer/render_view_impl_android.cc:64:
compositor_->UpdateTopControlsState(ContentToCc(constraints),
On 2015/02/12 13:51:48, majidvp wrote:
> That sounds good. In which case to be consistent I suggest we do the same for
> TopContrtolsHeight, and TopControlsShrinkBlinkSize and plumb them from Blink
to
> CC via WebLayerTreeView API and remove it from here:

Sounds good, go ahead.

[majidvp, 2015-02-12 22:36:45]

Patchset #3 (id:40001) has been deleted

[majidvp, 2015-02-12 22:55:33]

On 2015/02/12 19:24:55, aelias wrote:
>
https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
> File content/renderer/render_view_impl_android.cc (right):
> 
>
https://codereview.chromium.org/814083004/diff/20001/content/renderer/render_...
> content/renderer/render_view_impl_android.cc:64:
> compositor_->UpdateTopControlsState(ContentToCc(constraints),
> On 2015/02/12 13:51:48, majidvp wrote:
> > That sounds good. In which case to be consistent I suggest we do the same
for
> > TopContrtolsHeight, and TopControlsShrinkBlinkSize and plumb them from Blink
> to
> > CC via WebLayerTreeView API and remove it from here:
> 
> Sounds good, go ahead.

PTAL.

[aelias_OOO_until_Jul13, 2015-02-13 00:58:47]

lgtm, modulo please add a unit test along the lines of
LayerTreeHostImplWithTopControlsTest.TopControlsAnimationAfterScroll that
main-thread fling has the desired effect.

[majidvp, 2015-02-18 20:50:25]

New patchsets have been uploaded after l-g-t-m from aelias@chromium.org

[majidvp, 2015-02-19 17:32:22]

majidvp@chromium.org changed reviewers:
+ sievers@chromium.org

[majidvp, 2015-02-19 17:32:22]

+sievers for content/renderer owners review.

[no sievers, 2015-02-19 19:51:37]

lgtm

https://codereview.chromium.org/814083004/diff/120001/content/renderer/gpu/re...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/814083004/diff/120001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:167: static
cc::TopControlsState ConvertTopControlsState(
nit: don't need static here since you are in the anonymous namespace

https://codereview.chromium.org/814083004/diff/120001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:759:
layer_tree_host_->SetTopControlsHeight(height, shrink);
nit: indent

[majidvp, 2015-02-22 00:29:07]

New patchsets have been uploaded after l-g-t-m from sievers@chromium.org

[majidvp, 2015-02-22 01:42:59]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2015-02-22 01:43:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/814083004/160001

[commit-bot: I haz the power, 2015-02-22 01:46:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-22 01:46:38]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[majidvp, 2015-02-23 14:14:19]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2015-02-23 14:15:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/814083004/160001

[commit-bot: I haz the power, 2015-02-23 14:15:58]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2015-02-23 14:16:37]

Patchset 8 (id:??) landed as
https://crrev.com/fb80e434a19801b56124a8175bc03b9844f87db5
Cr-Commit-Position: refs/heads/master@{#317581}