Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 813893002: XKB RMLVO splitting. (Closed)

Created:
6 years ago by kpschoedel
Modified:
6 years ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

XKB RMLVO splitting. Layouts with a variant part (e.g. "us(altgr-intl)") could not be selected. BUG=362698 TEST=manual on link_freon Committed: https://crrev.com/e9a82b8201ec476695935926c4c9dc36adc5a03c Cr-Commit-Position: refs/heads/master@{#309050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
kpschoedel
fengyuan@, I don't know who defines the supported layout names, but perhaps we should refactor ...
6 years ago (2014-12-17 21:42:43 UTC) #3
FengYuan
On 2014/12/17 21:42:43, kpschoedel wrote: > fengyuan@, I don't know who defines the supported layout ...
6 years ago (2014-12-18 05:12:43 UTC) #4
FengYuan
lgtm
6 years ago (2014-12-18 05:14:11 UTC) #5
alexst (slow to review)
lgtm
6 years ago (2014-12-18 15:07:31 UTC) #7
spang
lgtm
6 years ago (2014-12-18 18:25:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813893002/1
6 years ago (2014-12-18 18:26:22 UTC) #10
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
6 years ago (2014-12-18 18:26:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813893002/1
6 years ago (2014-12-18 18:34:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 19:14:48 UTC) #16
commit-bot: I haz the power
6 years ago (2014-12-18 19:15:55 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9a82b8201ec476695935926c4c9dc36adc5a03c
Cr-Commit-Position: refs/heads/master@{#309050}

Powered by Google App Engine
This is Rietveld 408576698