Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

Issue 813893002: XKB RMLVO splitting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
index 4e15b2b01c2790608d33bb62e680dea6b3127476..4ebd6390422f9ae6060edffb51c8fa543195f16a 100644
--- a/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
@@ -647,17 +647,20 @@ bool XkbKeyboardLayoutEngine::CanSetCurrentLayout() const {
bool XkbKeyboardLayoutEngine::SetCurrentLayoutByName(
const std::string& layout_name) {
#if defined(OS_CHROMEOS)
- size_t dash_index = layout_name.find("-");
- size_t parentheses_index = layout_name.find("(");
+ size_t dash_index = layout_name.find('-');
+ size_t parentheses_index = layout_name.find('(');
std::string layout_id = layout_name;
std::string layout_variant = "";
- if (dash_index != std::string::npos) {
- layout_id = layout_name.substr(0, dash_index);
- layout_variant = layout_name.substr(dash_index + 1);
- } else if (parentheses_index != std::string::npos) {
+ if (parentheses_index != std::string::npos) {
layout_id = layout_name.substr(0, parentheses_index);
+ size_t close_index = layout_name.find(')', parentheses_index);
+ if (close_index == std::string::npos)
+ close_index = layout_name.size();
layout_variant = layout_name.substr(parentheses_index + 1,
- layout_name.size() - 1);
+ close_index - parentheses_index - 1);
+ } else if (dash_index != std::string::npos) {
+ layout_id = layout_name.substr(0, dash_index);
+ layout_variant = layout_name.substr(dash_index + 1);
}
struct xkb_rule_names names = {
.rules = NULL,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698