Source/platform/WebThread.cpp - Issue 813883002: replace COMPILE_ASSERT with static_assert in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/WebThread.cpp

Issue 813883002: replace COMPILE_ASSERT with static_assert in platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: another fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/CrossThreadCopier.h ('K') | « Source/platform/PODFreeListArena.h ('k') | Source/platform/animation/AnimationUtilities.h » ('j') | Source/platform/exported/WebCryptoAlgorithm.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/WebThread.cpp

diff --git a/Source/platform/WebThread.cpp b/Source/platform/WebThread.cpp

index 33a29ab63962034d12e6dc2b54b1345368055b7f..8b82e64d918325e3635601cd9ecea90d2d91c436 100644

--- a/Source/platform/WebThread.cpp

+++ b/Source/platform/WebThread.cpp

@@ -15,9 +15,9 @@

namespace {

#if OS(WIN)

-COMPILE_ASSERT(sizeof(blink::PlatformThreadId) >= sizeof(DWORD), Size_of_platform_thread_id_is_too_small);

+static_assert(sizeof(blink::PlatformThreadId) >= sizeof(DWORD), "Size of platform thread id is too small");

Nico 2014/12/17 23:24:43 nit: lower-case S

Mostyn Bramley-Moore 2014/12/17 23:33:54 Done.

#elif OS(POSIX)

-COMPILE_ASSERT(sizeof(blink::PlatformThreadId) >= sizeof(pid_t), Size_of_platform_thread_id_is_too_small);

+static_assert(sizeof(blink::PlatformThreadId) >= sizeof(pid_t), "Size of platform thread id is too small");

Nico 2014/12/17 23:24:43 nit: lower-case S

Mostyn Bramley-Moore 2014/12/17 23:33:54 Done.

#else

#error Unexpected platform

#endif