Source/platform/CrossThreadCopier.h - Issue 813883002: replace COMPILE_ASSERT with static_assert in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/CrossThreadCopier.h

Issue 813883002: replace COMPILE_ASSERT with static_assert in platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: another fixup Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/CrossThreadCopier.h

diff --git a/Source/platform/CrossThreadCopier.h b/Source/platform/CrossThreadCopier.h

index a1f593e34c48edfa5132b28b7c595b0961e68641..754e539a08b619072f5699f8bf160051619df242 100644

--- a/Source/platform/CrossThreadCopier.h

+++ b/Source/platform/CrossThreadCopier.h

@@ -82,10 +82,10 @@ namespace blink {

typedef typename WTF::RemovePointer<TypeWithoutPassRefPtr>::Type RefCountedType;

// Verify that only one of the above did a change.

- COMPILE_ASSERT((WTF::IsSameType<RefPtr<RefCountedType>, T>::value

+ static_assert((WTF::IsSameType<RefPtr<RefCountedType>, T>::value

|| WTF::IsSameType<PassRefPtr<RefCountedType>, T>::value

|| WTF::IsSameType<RefCountedType*, T>::value),

- OnlyAllowOneTypeModification);

+ "Only one type modification should be allowed");

Nico 2014/12/17 23:24:43 nit: lower-case O (see other review)

Mostyn Bramley-Moore 2014/12/17 23:33:54 Done.

typedef PassRefPtr<RefCountedType> Type;

static Type copy(const T& refPtr)

« no previous file with comments | « no previous file | Source/platform/CrossThreadCopier.cpp » ('j') | Source/platform/WebThread.cpp » ('J')