chrome/common/extensions/extension_permission_set_unittest.cc - Issue 8138004: Fix issues related to <all_urls> in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_permission_set_unittest.cc

Issue 8138004: Fix issues related to <all_urls> in extensions. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make the plugin.dll empty so it loads everywhere Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_permission_set_unittest.cc

diff --git a/chrome/common/extensions/extension_permission_set_unittest.cc b/chrome/common/extensions/extension_permission_set_unittest.cc

index c83e793a040e124e2447ca3413913d2ba0119bd1..5392217dea33fa30db1d6a8a51a02dddfaa51283 100644

--- a/chrome/common/extensions/extension_permission_set_unittest.cc

+++ b/chrome/common/extensions/extension_permission_set_unittest.cc

@@ -345,8 +345,8 @@ TEST(ExtensionPermissionSetTest, CreateUnion) {

AddPattern(&expected_explicit_hosts, "http://*.example.com/*");

AddPattern(&expected_scriptable_hosts, "http://*.google.com/*");

- effective_hosts.ClearPatterns();

- AddPattern(&effective_hosts, "<all_urls>");

+ URLPatternSet::CreateUnion(

+ explicit_hosts2, scriptable_hosts2, &effective_hosts);

set2 = new ExtensionPermissionSet(apis2, explicit_hosts2, scriptable_hosts2);

union_set = ExtensionPermissionSet::CreateUnion(set1.get(), set2.get());