chrome/common/extensions/extension_permission_set.cc - Issue 8138004: Fix issues related to <all_urls> in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_permission_set.cc

Issue 8138004: Fix issues related to <all_urls> in extensions. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: make the plugin.dll empty so it loads everywhere Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_permission_set.cc

diff --git a/chrome/common/extensions/extension_permission_set.cc b/chrome/common/extensions/extension_permission_set.cc

index 417da8f2264fce4e12da465b6195005198dad971..fde28eea2acc0a09e1bd30876e6c48e5846449d2 100644

--- a/chrome/common/extensions/extension_permission_set.cc

+++ b/chrome/common/extensions/extension_permission_set.cc

@@ -750,13 +750,6 @@ std::set<std::string> ExtensionPermissionSet::GetDistinctHosts(

void ExtensionPermissionSet::InitEffectiveHosts() {

effective_hosts_.ClearPatterns();

- if (HasEffectiveAccessToAllHosts()) {

- URLPattern all_urls(URLPattern::SCHEME_ALL);

- all_urls.SetMatchAllURLs(true);

- effective_hosts_.AddPattern(all_urls);

- return;

- }

URLPatternSet::CreateUnion(

explicit_hosts(), scriptable_hosts(), &effective_hosts_);

}