Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 813563004: Add vendorid and deviceid to webglinfo. (Closed)

Created:
5 years, 11 months ago by sivag
Modified:
5 years, 10 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add vendorid and deviceid to webglinfo. Chromium side patch to populate this info https://codereview.chromium.org/800483002/ Blink side patch to use this info and test this. https://codereview.chromium.org/826363002/ BUG=412440 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189098

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M public/platform/WebGraphicsContext3D.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sivag
ptal..
5 years, 11 months ago (2014-12-30 14:28:16 UTC) #2
Ken Russell (switch to Gerrit)
Sorry for the long delay. LGTM
5 years, 11 months ago (2015-01-23 23:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813563004/20001
5 years, 10 months ago (2015-01-28 06:57:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/25157)
5 years, 10 months ago (2015-01-28 07:03:16 UTC) #8
philipj_slow
lgtm
5 years, 10 months ago (2015-01-28 07:35:24 UTC) #10
sivag
On 2015/01/28 07:35:24, philipj_UTC7 wrote: > lgtm Thanks philip.
5 years, 10 months ago (2015-01-28 07:36:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813563004/20001
5 years, 10 months ago (2015-01-28 07:36:21 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 08:58:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189098

Powered by Google App Engine
This is Rietveld 408576698