Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: golden/go/expstorage/expstorage_test.go

Issue 813443002: Overhaul database package (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: golden/go/expstorage/expstorage_test.go
diff --git a/golden/go/expstorage/expstorage_test.go b/golden/go/expstorage/expstorage_test.go
index d67766f3a4dbc0343dd706041e5ed55aba13c807..2e09f31529ad632bf54eb28608a51e923056d261 100644
--- a/golden/go/expstorage/expstorage_test.go
+++ b/golden/go/expstorage/expstorage_test.go
@@ -14,21 +14,7 @@ import (
"skia.googlesource.com/buildbot.git/golden/go/types"
)
-func TestExpectationStores(t *testing.T) {
- // Test the memory store.
- memStore := NewMemExpectationsStore()
- testExpectationStore(t, memStore)
-
- // Initialize the DB to use a local SQLite instances.
- vdb := database.NewVersionedDB(&database.DatabaseConfig{
- SQLiteFilePath: "correctness.db",
- MigrationSteps: db.MigrationSteps(),
- })
- sqlStore := NewSQLExpectationStore(vdb)
- testExpectationStore(t, sqlStore)
-}
-
-func TestMySQLExpecatationsStore(t *testing.T) {
+func TestMySQLExpectationsStore(t *testing.T) {
// Set up the database and make sure it's at the right version.
conf := &database.DatabaseConfig{
MySQLString: testutil.GetTestMySQLConnStr(t, "root", "correctness"),

Powered by Google App Engine
This is Rietveld 408576698