Overhaul database package

golden/go/expstorage/expstorage_test.go

 package expstorage
 
 import (
         "testing"
 )
 
 import (
         // Using 'require' which is like using 'assert' but causes tests to fail.
         assert "github.com/stretchr/testify/require"
 
         "skia.googlesource.com/buildbot.git/go/database"
         "skia.googlesource.com/buildbot.git/go/database/testutil"
         "skia.googlesource.com/buildbot.git/golden/go/db"
         "skia.googlesource.com/buildbot.git/golden/go/types"
 )
 
-func TestExpectationStores(t *testing.T) {
-        // Test the memory store.
-        memStore := NewMemExpectationsStore()
-        testExpectationStore(t, memStore)
-
-        // Initialize the DB to use a local SQLite instances.
-        vdb := database.NewVersionedDB(&database.DatabaseConfig{
-                SQLiteFilePath: "correctness.db",
-                MigrationSteps: db.MigrationSteps(),
-        })
-        sqlStore := NewSQLExpectationStore(vdb)
-        testExpectationStore(t, sqlStore)
-}
-
-func TestMySQLExpecatationsStore(t *testing.T) {
+func TestMySQLExpectationsStore(t *testing.T) {
         // Set up the database and make sure it's at the right version.
         conf := &database.DatabaseConfig{
                 MySQLString:    testutil.GetTestMySQLConnStr(t, "root", "correctness"),
                 MigrationSteps: db.MigrationSteps(),
         }
 
         // Lock to serialize DB tests
         lockVdb := testutil.GetMySQlLock(t, conf)
         defer func() {
                 testutil.ReleaseMySQLLock(t, lockVdb)
@@ skipping 63 matching lines @@
         assert.Equal(t, types.TestClassification(map[string]types.Label{DIGEST_21: types.POSITIVE}), foundExps.Tests[TEST_2])
 
         changeExps.RemoveDigests([]string{DIGEST_12})
         err = store.Put(changeExps, "user-3")
         assert.Nil(t, err)
 
         foundExps, err = store.Get(false)
         assert.Nil(t, err)
         assert.Equal(t, 1, len(foundExps.Tests))
 }